Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v17] Document second_factors field #50801

Merged
merged 2 commits into from
Jan 9, 2025
Merged

[v17] Document second_factors field #50801

merged 2 commits into from
Jan 9, 2025

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Jan 6, 2025

Backport #49016 to branch/v17

@Joerger
Document second_factors field (#49016)
f5d1593 
* Document second_factors; Update test plan.

* Update proto comment; Update terraform docs.

* Clarify second_factors reference.

* Fix docs lint.

* Address comments.

* Address marco's comment.
@Joerger Joerger changed the title Document second_factors field (#49016) [v17] Document second_factors field Jan 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
joerger/v17/second-factors-docs efb8ade 2 ✅SUCCEED joerger-v17-second-factors-docs 2025-01-08 23:48:50

@Joerger Joerger added the no-changelog Indicates that a PR does not require a changelog entry label Jan 8, 2025
@Joerger Joerger enabled auto-merge January 8, 2025 23:43
@Joerger Joerger added this pull request to the merge queue Jan 9, 2025
Merged via the queue into branch/v17 with commit a616b98 Jan 9, 2025
43 checks passed
@Joerger Joerger deleted the joerger/v17/second-factors-docs branch January 9, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoandredinis marcoandredinis marcoandredinis approved these changes

@rosstimothy rosstimothy rosstimothy approved these changes

Assignees
No one assigned
Labels
backport documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joerger @marcoandredinis @rosstimothy